[OMM] Remove validation masking, update spec #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tex3d
reviewed
Jan 30, 2025
tex3d
reviewed
Jan 30, 2025
tex3d
reviewed
Jan 30, 2025
tex3d
reviewed
Jan 30, 2025
tex3d
reviewed
Jan 30, 2025
tex3d
reviewed
Jan 30, 2025
tex3d
reviewed
Jan 30, 2025
tex3d
requested changes
Jan 30, 2025
tex3d
reviewed
Jan 31, 2025
tex3d
reviewed
Jan 31, 2025
tex3d
reviewed
Jan 31, 2025
tex3d
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No validation mask is needed for the new OMM flags. Source level validation is still needed to ensure the flags are used correctly, but the validator will not need to run the flags through a mask to validate them. Additionally, this PR removes any mention of flag value validation, except for one specific case where a RayQuery ray flag template argument necessitates the RayQuery ray query flag template argument's value.
This PR updates the spec to reflect new changes to the validator, and proposes some new diagnostics with the new RAYQUERY_FLAG_ALLOW_OPACITY_MICROMAPS flag. It defines a new DXIL OP,
AllocateRayQuery2, which will be generated when RayQuery is given a 2nd, optional, ray query template flag argument in HLSL.This PR is a transfer from #374
Fixes #375
Fixes #360